Report - The Approve Button Still Displays For Aprrover A After Clicking On It

by ADMIN 79 views

Report - The Approve Button Still Displays for Approver A After Clicking on It

In this report, we will be discussing an issue where the Approve button still displays for Approver A after clicking on it. This issue was reported by the Applause Internal Team and is reproducible on the MacOS platform using Chrome and Safari browsers.

Version Number and Reproducibility

  • Version Number: v9.1.28-13 PR:59999
  • Reproducible in staging?: No
  • Reproducible in production?: No

Action Performed

Preconditions

Before we begin, let's set up the preconditions for this issue.

  • Control workspace has advanced approval set with 2 approvers
  • Employee has submitted a report to the Owner's workspace

Control Approval Flow Guide and Reference

For reference, the control approval flow guide is as follows:

  • Employee submits to approver A
  • The second approver is Approver B
  • Approver B is the final approver

Other Configurations

  • Set Submission frequency to Manually
  • Rules are disabled
  • Make or track payments set to "Disabled"

Steps

Now, let's walk through the steps to reproduce this issue.

  1. Setup in preconditions is complete
  2. Approver A steps:
    • Log in as Approver A
    • Verify the workspace chat for the employee has a GBR as an action is required
    • Navigate to the workspace chat of the employee
    • Verify that you see a whisper message in the employee workspace chat notifying you that a report is awaiting your approval
    • Click on the header
    • Click on members
    • Verify the members listed are: employee, approver A and approver B
    • Navigate back to the report
    • Verify the next steps mention that "Waiting for [Approver A] to approve these expense(s)"
    • Click on the Approve button on the expense
    • Click on it again

Expected Result

The expected result is that the Approve button dismisses and the Next Step reads “Waiting for [Approver B] to approve expense(s)”.

Actual Result

The actual result is that the Approve button still displays in the report Admin A after clicking on the Approve button, and clicking on it again displays an error.

Workaround

Unfortunately, there is no known workaround for this issue.

Platforms

This issue is reproducible on the following platforms:

  • MacOS: Chrome / Safari

Screenshots/Videos

A screenshot of this issue can be found here:

https://github.com/user-attachments/assets/246e4bd6-07ba-4a85-b2c2-03d9de0f518f

Conclusion

In conclusion, this report highlights an issue where the Approve button still displays for Approver A after clicking on it. This issue is reproducible on the MacOS platform using Chrome and Safari browsers. We hope that this report will help to identify and resolve this issue.

Additional Information

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Related Issues

If you are experiencing similar issues, please check out the following related issues:

View All Open Jobs on GitHub

If you are interested in contributing to our project, please check out the following open jobs on GitHub:

In our previous report, we discussed an issue where the Approve button still displays for Approver A after clicking on it. In this Q&A article, we will be answering some frequently asked questions related to this issue.

Q: What is the expected behavior when Approver A clicks on the Approve button?

A: The expected behavior is that the Approve button dismisses and the Next Step reads “Waiting for [Approver B] to approve expense(s)”.

Q: What is the actual behavior when Approver A clicks on the Approve button?

A: The actual behavior is that the Approve button still displays in the report Admin A after clicking on the Approve button, and clicking on it again displays an error.

Q: Is this issue reproducible on all platforms?

A: No, this issue is only reproducible on the MacOS platform using Chrome and Safari browsers.

Q: What are the preconditions for this issue?

A: The preconditions for this issue are:

  • Control workspace has advanced approval set with 2 approvers
  • Employee has submitted a report to the Owner's workspace

Q: What are the steps to reproduce this issue?

A: The steps to reproduce this issue are:

  1. Log in as Approver A
  2. Verify the workspace chat for the employee has a GBR as an action is required
  3. Navigate to the workspace chat of the employee
  4. Verify that you see a whisper message in the employee workspace chat notifying you that a report is awaiting your approval
  5. Click on the header
  6. Click on members
  7. Verify the members listed are: employee, approver A and approver B
  8. Navigate back to the report
  9. Verify the next steps mention that "Waiting for [Approver A] to approve these expense(s)"
  10. Click on the Approve button on the expense
  11. Click on it again

Q: Is there a known workaround for this issue?

A: No, there is no known workaround for this issue.

Q: How can I contribute to resolving this issue?

A: If you are interested in contributing to resolving this issue, please check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Q: What are some related issues that I should be aware of?

A: Some related issues that you should be aware of are:

Q: Where can I find more information about this issue?

A: You can find more information about this issue in our previous report: Report - The Approve Button Still Displays for Approver A After Clicking on It.

Conclusion

In conclusion, this Q&A article provides answers to some frequently asked questions related to the issue where the Approve button still displays for Approver A after clicking on it. We hope that this article will help to clarify any confusion and provide a better understanding of this issue.